Add a new "model alerts" webview (for showing results from model evaluation)#3436
Merged
shati-patel merged 5 commits intomainfrom Mar 5, 2024
Merged
Add a new "model alerts" webview (for showing results from model evaluation)#3436shati-patel merged 5 commits intomainfrom
shati-patel merged 5 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Works for me, though it would be good to clean up the types before merging.
| import { showAndLogExceptionWithTelemetry } from "../../common/logging"; | ||
|
|
||
| export class ModelAlertsView extends AbstractWebview< | ||
| ToDataFlowPathsMessage, |
Contributor
There was a problem hiding this comment.
Can we define new types instead of reusing the DataFlowPaths types
Contributor
Author
There was a problem hiding this comment.
Oooops, I thought I'd already fixed that! Thanks 🤦🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a (currently empty) "Model alerts" webview, which can be opened by clicking "Evaluation run" from the model editor. In future, this will be populated with evaluation results, but for now it looks like this 😂
4FFC53E6-4870-49B6-926E-CBF5E13505E4.MP4
See internal linked issue for more context and future work!
Checklist
N/A (feature-flagged for internal use)
ready-for-doc-reviewlabel there.